fix(frontend): resolve issues #879, #877, #875, #873 - #921
Merged
ogazboiz merged 1 commit intoJun 29, 2026
Merged
Conversation
…#875, LabsCrypt#873 - testing, colors, consolidation, metadata ## Issue LabsCrypt#879: Add tests for lib/amount.ts - Create comprehensive test suite for src/lib/amount.ts - Test formatAmount/parseAmount round-trip validation - Validate hasValidPrecision for stream creation wizard - Test formatRate, truncateAmount, and formatCompactAmount - Add regression tests for wizard validation flow ## Issue LabsCrypt#877: Replace hardcoded hex colors with CSS variables - Replace #b12f3f, #8f2a38, #8c2230 with var(--danger) - Update .activity-item span.is-negative - Update .dashboard-error-state h3 - Update .secondary-button--danger - Update .wallet-error and .wallet-dropdown__warning ## Issue LabsCrypt#875: Consolidate TransactionTracker components - Remove redundant components/ui/TransactionTracker.tsx - Migrate StreamCreationWizard to inline step display - Keep main TransactionTracker for incoming/page and ActivityHistory - Eliminate duplicate component APIs ## Issue LabsCrypt#873: Add metadata for social sharing - Add metadataBase: https://flowfi.app - Configure OpenGraph tags (title, description, url, siteName, images) - Add Twitter card configuration (summary_large_image) - Set canonical URL via alternates Closes LabsCrypt#879 Closes LabsCrypt#877 Closes LabsCrypt#875 Closes LabsCrypt#873
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 4 frontend issues with comprehensive fixes for testing, design tokens, component consolidation, and metadata:
Issue #879: Create tests for lib/amount.ts
src/lib/amount.tsformatAmount/parseAmountround-trip correctnesshasValidPrecision,formatRate,truncateAmount, andformatCompactAmountIssue #877: Replace hardcoded colors with CSS variables
var(--danger).activity-item span.is-negative,.dashboard-error-state h3,.secondary-button--danger,.wallet-error,.wallet-dropdown__warningIssue #875: Consolidate TransactionTracker components
components/ui/TransactionTracker.tsxStreamCreationWizardto use inline step displaycomponents/TransactionTracker.tsxfor incoming/page and ActivityHistoryIssue #873: Add metadata for social sharing
metadataBasefor absolute URL resolutionChanges
frontend/src/__tests__/lib.amount.test.tswith 150+ lines of testsfrontend/src/app/globals.cssto use CSS variablesfrontend/src/app/layout.tsxwith complete metadatafrontend/src/components/stream-creation/StreamCreationWizard.tsxwith inline step displayfrontend/src/components/ui/TransactionTracker.tsxTest Plan
npm run testin frontend directory to verify all tests passnpm run lintnpm run buildCloses #879
Closes #877
Closes #875
Closes #873